alan-turing-institute / alan-turing-institute/ReadabiliPy

Bug in extracted images sources returning a base64

Open
#92 13 comments 0 reactions 1 assignee Claimed by @martintoreilly View on GitHub
bug
Dominant language
HTML
Stars
359
Forks
44
PR merge metrics
No merged PRs in 30d

Description

## Solution
Added by @martintoreilly
1. (minimal fix): update our local copy of Readability.js to the latest file from the Mozilla package
2. (better): stop duplicating Readability.js as a local copy and instead reference the Mozilla package directly (but double check why we opted for a local copy first)

## Original issue
Raised by @cayolblake
Hello,

Any idea why original tag on site looks like the following.

`Ursula von der Leyen, who trained as a physician before going into politics, pictured with her husband and seven children in 2005.
`

And the extracted one looks like the following with the "src" attribute messed up?

``

Basically, `src="//cdn.cnn.com/cnnnext/dam/assets/190714161615-ursula-von-der-leyen-children-exlarge-169.jpg" ` ends up being `src="image/gif;base64,R0lGODlhEAAJAJEAAAAAAP///////wAAACH5BAEAAAIALAAAAAAQAAkAAAIKlI+py+0Po5yUFQA7" `

What to do to avoid such behavior?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.