akveo / akveo/nebular

Remove redundant "title" attribute from menu items

未关闭
#2,888 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
8.1k
派生
1.5k
PR 合并指标
30 天内没有已合并 PR

描述

### Issue type

**I'm submitting a ...** (check one with "x")

* [ ] bug report
* [x] feature request

### Issue description

**Current behavior:**
We are using Nebular and evaluated our app with WAVE accessibility evaluation tool, and got warning "Redundant title text" for every item in the nb-menu. The root of the problem is that every menu item sets the `[attr.title]="menuItem.title"` title but the menu text is exactly the same. For further info: https://accessibilitytips.com/2008/04/14/avoiding-redundant-title-attributes/

**Expected behavior:**
Remove the title attribute.

### Other information:

this patch should fix the issue

[patch.txt](https://github.com/akveo/nebular/files/7309601/patch.txt)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。