akveo / akveo/nebular

`@nebular/auth` should not depend on `@nebular/theme`

Open
#2,437 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
8.1k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

### Issue type

**I'm submitting a ...**

* [x] bug report
* [ ] feature request

### Issue description

**Current behavior:**
Can not use nebular OAuth2Strategy without `@nebular/theme`

**Expected behavior:**
`@nebular/auth` should not depend on `@nebular/theme`

`NbOAuth2AuthStrategy` uses the `NB_WINDOW` injectiontoken from `@nebular/theme`, and so my application has to list it as a dependency, even though I'm not using Nebular's UI system.
Besides, NB_WINDOW just resolves to the global `window` object...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.