akveo / akveo/nebular

Sidebar partially shown under the header (3.6.2)

未关闭
#1,855 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
3.x.x module:components needs triage
主要语言
TypeScript
星标
8.1k
派生
1.5k
PR 合并指标
30 天内没有已合并 PR

描述

### Issue type

**I'm submitting a ...**

* [x] bug report
* [ ] feature request

### Issue description

**Current behavior:**
In version 3.6.2, the sidebar is shown at a different height (i.e. with a different `top` value in the CSS).
This causes the sidebar to partially overlap with the header:

This is caused by the following line of code:
https://github.com/akveo/nebular/blob/e5a04b6fb2b3cdf6e76f8294cbeaffa37427e8a1/src/framework/theme/components/layout/_layout.component.theme.scss#L161
Which calculates the top to be 4.25em (for the default theme), not taking into account the additional 2rem margin for between the header and the content.

**Expected behavior:**
The sidebar should have some margin with the header, and not overlap (like it used to in 3.6.0 and earlier versions)

**Steps to reproduce:**

Just add any standard sidebar:
https://stackblitz.com/edit/nebular-sidebar-issue

**Related code:**

Please refer to my stackblitz:
https://stackblitz.com/edit/nebular-sidebar-issue

### Other information:

**npm, node, OS, Browser**
```
Node 10.15.3
NPM 6.10.1
OS: Windows 10
Browser: tested in Chrome/Firefox
```

**Angular, Nebular**
```
Angular: 8.1.2
@nebular/theme: 3.6.2 | 3.6.1
```
The issue doesn't happen in Nebular `3.6.0`, so my current workaround is to enforce that version of `@nebular/theme`

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。