akveo / akveo/nebular

Scrollbar Radius Not Implemented

Abierto
#1,194 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug module:theme P3: minor
Lenguaje dominante
TypeScript
Estrellas
8.1k
Forks
1.5k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

### Issue type

**I'm submitting a ...** (check one with "x")

* [x] bug report
* [ ] feature request

### Issue description

**Current behavior:**
When specifying a "scrollbar-thumb-radius" in a nebular theme, the radius is not utilized.

The reason for this is that while the nb-scrollbars mixin has a parameter for radius (the fourth parameter), _none_ of the calls to the mixin specify a radius, so the default of "$size / 2" is always used. This isn't evident in the built-in themes (light, corporate, cosmic) because the default radius in these themes is actually half the "scrollbar-width."

The nb-scrollbars() calls that fail to pass the fourth parameter (radius) are in:

- _modals.scss
- _alert.component.theme.scss
- _card.component.theme.scss (2)
- _chat.component.theme.scss
- _layout.component.theme.scss
- _route-tabset.component.theme.scss
- _sidebar.component.theme.scss
- _tabset.component.theme.scss

**Expected behavior:**
The "scrollbar-thumb-radius" setting in the theme files is used for scrollbars.

**Steps to reproduce:**
Set a custom theme's scrollbar settings to match the following:
scrollbar-width: 15px,
scrollbar-thumb-radius: 0px,

**Related code:**

```
Not applicable.
```

### Other information:

**npm, node, OS, Browser**
```
npm: 6.4.1
node: 8.11.4
OS: win32 x64
browser: Chrome 71.0.3578.98 64-bit
```

**Angular, Nebular**
```
Angular: 7.2.2
Nebular: 3.1.0
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.