rememberMe unused in NbAuthService
Ouverte
enhancement
help wanted
module:auth
needs docs
- Langage dominant
- TypeScript
- Étoiles
- 8.1k
- Forks
- 1.5k
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Hi Akveo,
I see that when using NbAuthService for login:
`authService.authenticate('provider', 'data)...`
The rememberMe checkbox (from your NbLoginComponent) is never checked before saving the token into TokenService
https://github.com/akveo/nebular/blob/893d56adfe56a0d4f6e8fe9b9591a20e3bafade4/src/framework/auth/services/auth.service.ts#L134
Result: token is always saved (even if checkbox not checked). So when I close my browser and visit again, I'm still logged (token is still here because I did not logout).
Is this normal behavior ?
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.