aksonov / aksonov/react-native-router-flux

Can we make navigationStore.defaultSuccess and navigationStore.defaultFailure customizable?

未關閉
#3,517 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
8.9k
分支
2.1k
PR 合併指標
30 天內沒有已合併 PR

描述

### Version
Tell us which versions you are using:
- react-native-router-flux v4.0.6
- react v16.8.3
- react-native v0.59.8

### Expected behaviour

If `Component.onEnter` or `Component.onExit` fails, I want to be able to catch and log errors.

### Actual behaviour

- it works for `onEnter` right now, the only caveat is that you need to declare a `failure()` handler on each ``, making the feature unusable on the long term
- there is no way to achieve this of `onExit`

Code is located here:

https://github.com/aksonov/react-native-router-flux/blob/1a1d0f65d0db76084dbe47f90bb0eb495cf8792b/src/navigationStore.js#L530-L564

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。