akshitagupta15june / akshitagupta15june/PetMe

Better fill colors for Facebook and GitHub links in the footer

Ouverte
#1,245 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
HTML
Étoiles
515
Forks
747
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Is your feature request related to a problem? Please describe.**
The icon link for GitHub at the footer has very poor contrast and therefore is hard to read.
![image](https://github.com/akshitagupta15june/PetMe/assets/56351143/78de2b4f-124e-4e41-9788-9695c8af1881)

**Describe the solution you'd like**
I would like to change these default and hover colors for the GitHub icon to `#ccc` and `white` respectively. Inspired by the following site: https://dunks1980.com/

![image](https://github.com/akshitagupta15june/PetMe/assets/56351143/436c42bb-437a-4a65-a95d-338c4af2eb88)

This will result in better readability and contrast.

While I'm at it, I would also like to change the default color of the Facebook icon to match with the GitHub icon. And also change the hover fill color to the appropriate official Facebook primary color on their website:

![image](https://github.com/akshitagupta15june/PetMe/assets/56351143/805b15ae-1ae4-420b-a7ad-e86aa06dcd36)

**Proposed result*
Default state:
![image](https://github.com/akshitagupta15june/PetMe/assets/56351143/00d7c465-18d5-4cf8-b297-789c1fe94478)

Hover state:
![image](https://github.com/akshitagupta15june/PetMe/assets/56351143/93c7312d-78c9-4184-9985-8232d2fca63d)

As you can see this will result in better readability and consistency between the two icons.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.