RouteTest.trailer does not take into account attribute
- Dominant language
- Scala
- Stars
- 1.4k
- Forks
- 584
- Avg merge
- 14h 33m
- Merged PRs (30d)
- 24
Description
We currently have two ways to set a trailing header on the response:
* For HTTP/1.1 and HTTP/2 alike, set it in the LastChunk of a Chunked response
* For HTTP/2 only, use the `trailer` attribute
When testing, `RouteTest.trailer` will only show the trailer from the LastChunk, not from the attribute. We could consider exposing the trailer - though it could also incorrectly give the impression that that'd work on HTTP/1.1?
Contributor guide
Research direction
Start at RouteTest.trailer and trace how it reads the response trailer from the LastChunk. Compare that behavior with the HTTP/2 trailer attribute described in the issue, then identify the expected distinction between HTTP/1.1 and HTTP/2 and add coverage showing the intended result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100