akka / akka/akka-http

Should response/request.header[T] be ModeledCustomHeader aware?

Open
#1,102 4 comments 3 reactions 0 assignees View on GitHub
1 - triaged t:core t:docs
Dominant language
Scala
Stars
1.4k
Forks
584
Avg merge
14h 33m
Merged PRs (30d)
24

Description

This requires a bunch of hacks though, as the impl that makes it work in akka-http is the `HeaderMagnet` infra which we do not have immediately available in akka-http-core, and I'm not sure if we want to have it there.

https://github.com/akka/akka-http/blob/master/akka-http/src/main/scala/akka/http/javadsl/server/directives/HeaderDirectives.scala#L84

We can make it work using some smarts however making it possible for Java should likely use the partial function style as we suggest anyway for the routing DSL for it.

Contributor guide

Open the contributing guide

Research direction

Start with akka-http/src/main/scala/akka/http/javadsl/server/directives/HeaderDirectives.scala and the referenced HeaderMagnet implementation in akka-http. Determine whether response/request.header[T] should support ModeledCustomHeader, and whether the Java API should follow the partial-function style suggested for the routing DSL. Done means a decided, documented approach for akka-http-core and Java usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, scala
Domain
api, backend-api-design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.