akiran / akiran/react-slick

Arrows elements are polluted

Aperta
#2,051 1 commento 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
11.9k
Fork
2.1k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### Problem
When using arrows (`arrows: true`), elements used in `nextArrow` and `prevArrow` are polluted. Their `className` is changed entirely. Used Chrome DevTools to check the class list.

### Expected behaviour
Either:
a) embed the passed element in some `div` or
b) make the library append required classes (`slick-arrow`, `slick-next`) instead overwriting whole class list (the same would be with other fields possibly(?)).
c) add `nextArrowClassName`/`rightArrowClassName` (but its stupid tbh)

### Example code
https://codesandbox.io/s/react-slick-playground-forked-lew3o?file=/index.js
The example code includes part of https://react-slick.neostack.com/docs/example/custom-arrows .

### Workaround
Embed the passed element in dummy `div`. By the way, React `Fragment` won't do ('<>`).

_Tags: `[Not critical]`, `[Quality of Life]`_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.