akiran / akiran/react-slick

Calls .disconnect on resize observer, which doesn't exist

Open
#1,990 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
11.9k
Forks
2.1k
PR merge metrics
No merged PRs in 30d

Description

In the componentWillUnmount handler, `_this.ro.disconnect()` does not exist on the resize observer. After debugging it looks like the correct method is `.unobserve()`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.