akiran / akiran/react-slick

Enforce ARIA rule

Open
#1,535 22 comments 29 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
11.9k
Forks
2.1k
PR merge metrics
No merged PRs in 30d

Description

### DESCRIPTION
We can find `slick-slides` that have `aria-hidden="true"` and `tabindex="-1"` attributes. This breaks the ARIA rules to have any tabindex value (indicating the element is focusable) whilst also having the hidden flag for an element.

Found with 'Axe' Chrome extension to flag accessibility issues
Docs: https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=AxeChrome

Replicate here: https://codesandbox.io/s/ppwkk5l6xx

### CURRENT:
```

```

### EXPECTED:
```

```

**Solution**: tabindex attibute should be removed when `aria-hidden="true"`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.