akinsho / akinsho/toggleterm.nvim

[BUG] non-standard uri fragment

Abierto
#653 0 comentarios 3 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Lua
Estrellas
5.6k
Forks
206
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current Behavior

Toggleterm generates uri fragments that contain `#`, eg:

```
term://~/code/typos-lsp//59317:/bin/zsh;#toggleterm#1
```

This causes LSP servers using a strict URI parser to fail in toggleterm. See https://github.com/tower-lsp-community/tower-lsp-server/issues/65.

### Expected Behavior

According to [RFC 3986 Section 3.5](https://datatracker.ietf.org/doc/html/rfc3986#section-3.5) the use of `#` in a fragment like `toggleterm#1` is non-standard. Lenient parsers may allow this, but strict URI parsers fail.

To allow interoperability with LSP servers that use strict parsers, would you consider an alternative, for example percent encoding (ie: `%23`) the `#` in the fragment?

### Steps To Reproduce

Use toggleterm with typos-lsp and notice that it doesn't spell check.

### Environment

```Markdown

```

### Anything else?

Thank you!

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.