akash-network / akash-network/console
Fix missing proposer in proposal endpoint
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 264
- Forks
- 94
- Avg merge
- 18h 49m
- Merged PRs (30d)
- 297
Description
The proposer is never returned in the /proposals/{id} endpoint. The code was commented out because the akash proposer endpoint is returning an error for proposals created during genesis. On top of that, the workaround of checking for only post-genesis proposals (id > 3) doesn't work for sandbox/testnet.
Failing akash endpoint: https://akash-api.polkachu.com/gov/proposals/1/proposer
We need to:
- Make sure proposer is returned for all proposal (pre or post-genesis)
- Make sure this works with sandbox/testnet so no hardcoded proposal ids
We could also consider removing the endpoint or proposer entirely in the if there is no need for it anymore.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in api/src/services/external/apiNodeService.ts at the commented-out proposer lookup and reproduce the failing Akash proposer endpoint for genesis, sandbox, and testnet proposals. Determine whether the proposer endpoint should be retained or removed; done means the proposal endpoint consistently returns a proposer across environments, or the proposer field and dependency are removed if no longer needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend, blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100