akarnokd / akarnokd/akarnokd-misc

Implementation of toBeMaxed

Open
#10 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
54
Forks
20
Avg merge
1h 20m
Merged PRs (30d)
5

Description

The shakespeare benchmark implementation for j.u.s.Stream has this assignment :

https://github.com/akarnokd/akarnokd-misc/blob/78d57288030785bbf482a36213a3a27ef5fde575/src/jmh/java/hu/akarnokd/comparison/scrabble/ShakespearePlaysScrabbleWithStreams.java#L119-L121:

This would probably be more performant as this:

```java
Function toBeMaxed =
word -> IntStream.concat(first3.apply(word), last3.apply(word));
```

From a fairness perspective this should be tried because I notice the other Shakespeare implementations do this with the equivalent of `concat` rather than `flatMap`.

I'll be interested to see the results. By the way do you publish the benchmark results (those nifty graphs) somewhere (other than twitter)?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.