ajwheeler / ajwheeler/Korg.jl

NORAD opacities should be smoothed by default

Abierto
#564 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Julia
Estrellas
67
Forks
15
Merge medio
2 d 6 h
PR fusionados (30 d)
6

Descripción

Hi,

I've only recently taken a look at the continuum returned by korg, and I am seeing some strange features in the blue(see below) which seem to be at the level of a percent, but look like artifacts/numerical issues to me:

Image

This is obtained using latest 1.2.1 korg (from python). The stellar parameters here teff=4000,logg=5, and abundance corresponding to feh=-1,alpha=0 (I don't think this matters too much).

This is what I do:
```
X_H = np.array([ 1.200e+01, 1.093e+01, 5.000e-02, 3.800e-01, 1.700e+00,
7.390e+00, 6.780e+00, 7.660e+00, 3.560e+00, 6.840e+00,
5.170e+00, 6.530e+00, 5.370e+00, 6.510e+00, 4.360e+00,
6.140e+00, 4.500e+00, 5.180e+00, 4.080e+00, 5.310e+00,
2.170e+00, 3.900e+00, 3.000e+00, 4.640e+00, 4.390e+00,
6.450e+00, 3.920e+00, 5.230e+00, 3.210e+00, 3.600e+00,
1.880e+00, 2.580e+00, 1.290e+00, 2.330e+00, 1.560e+00,
2.250e+00, 1.600e+00, 1.920e+00, 1.210e+00, 1.580e+00,
4.200e-01, 9.200e-01, -6.000e+00, 8.400e-01, 1.200e-01,
6.600e-01, -6.000e-02, 7.700e-01, 6.000e-01, 1.000e+00,
0.000e+00, 1.190e+00, 5.100e-01, 1.240e+00, 7.000e-02,
1.170e+00, 1.300e-01, 7.000e-01, -4.200e-01, 4.500e-01,
-6.000e+00, 0.000e+00, -4.800e-01, 1.100e-01, -7.200e-01,
1.400e-01, -4.900e-01, -7.000e-02, -1.000e+00, 8.000e-02,
-9.400e-01, -1.200e-01, -1.170e+00, 1.100e-01, -7.700e-01,
2.500e-01, 3.800e-01, 6.400e-01, 1.000e-02, 1.300e-01,
-1.000e-01, 1.000e+00, -3.500e-01, -6.000e+00, -6.000e+00,
-6.000e+00, -6.000e+00, -6.000e+00, -6.000e+00, -9.400e-01,
-6.000e+00, -1.520e+00])
marcs = Korg.interpolate_marcs(float(4000),
float(5),
X_H,
clamp_abundances=True)
spec0 = Korg.synthesize(
marcs,
lines,
X_H,
(3100, 4000),
vmic=1,
line_buffer=100,
hydrogen_line_window_size=400,
cntm_step=0.1,
)
plt.plot(spec0.wavelengths, spec0.cntm)

```

lines variable is my VALD line-list (but presumably that shouldn't matter for the continuum).

Are the features that I am seeing an issue, or it is somehow expected from bf, etc ?

Thanks!

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.