ajwheeler / ajwheeler/Korg.jl

TODO

未关闭
#1 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Julia
星标
67
派生
15
平均合并
2 天 6 小时
30 天内合并 PR
6

描述

I mostly manage TODOs by opening new issues, but this list contains many ideas which I haven't taken the time to expand on.

- [ ] Add scattering (via ALI?) https://iopscience.iop.org/article/10.1088/0004-6256/141/6/175/pdf
- [ ] Stancil 1994 provided tables for He2plus in addition to H2plus bf and ff absorption (which we use). The data is already, in Korg, we just need to add it as an absorption mechanism. It should be checked whether this can conceivably ever matter before putting it in.
- [ ] compare D0 vals with those from ATcT (https://atct.anl.gov/Thermochemical%20Data/version%201.118/)
- [ ] Would be good to be able to compute some estimate of the "systematic error" as a function of wavelength
- [ ] could use the [vald accuracy parameters](https://www.astro.uu.se/valdwiki/VALD3_accuracy)
- [ ] improve package load time.
- [ ] Would be good to support both generic ABO recipes (given l for upper and lower states) for the sake of parity with turbospectrum.
- [ ] it would be nice to have the tutorial notebook integrated with the docs. This can be done with Literate.jl, e.g. https://ferrite-fem.github.io/Ferrite.jl/stable/examples/heat_equation/#Introduction
- [ ] H lines should have automatic windowing. See discussion in #140
- [ ] DataInterpolations now has multivariate cubic interpolation which we might want to lift for Korg. (Likely better to do tis by duplicating the source rather than adding the dependency since it's a bit heavy.) We are currently using multivariate linear interpolation in several places. It's important to make sure that we don't accidentally end up on the wrong side of the accuracy/speed tradeoff by doing this.
- [ ] Are we using the most up-to-date Stark broadening prescription? See discussion in Korg 2 paper.
- [ ] in [Including all the lines](https://cdnsciencepub.com/doi/10.1139/p10-104), Kurucz mentions depth-dependent microturbulent velocity. He is discussing opacities for model atmospheres, but I suspect also relevant for synthesis.
- [ ] we should do real convolution of stark and self-broadening profiles for H alpha, beta, and gamma
- [ ] Better default `gamma_rad` estimates. Can use more data about upper level and `J` when available. For diatomic molecules: http://articles.adsabs.harvard.edu/pdf/1983A%26A...128..291L.
- [ ] we load ionization energies from Barklem and Collet at import time, but it might be sensible to hardcode these. I think they are very well known and available from NIST. Don't do this without confirming that they are very well-known.
- [ ] better treatment of autoionizing lines? They should technically have Fano profiles (and broadening treatment needs a revision, I think).
- [ ] Should I include a Delta gamma_6 fudge factor for non-ABO lines?
- [ ] Zeeman broadening and polarized radiative transfer (e.g. https://arxiv.org/pdf/2303.11241.pdf)

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。