airvzxf / airvzxf/ftp-deployment-action

test(integration): scenarios can't run in parallel (fixed ports 2121/2122/2123)

未关闭
#223 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
audit pending-architecture pending-human priority:medium test
主要语言
Shell
星标
37
派生
9
平均合并
44 分钟
30 天内合并 PR
47

描述

gh issue create --title "test(integration): scenarios can't run in parallel (fixed ports 2121/2122/2123)" --label "test,audit,priority:medium" --body "## Finding

The integration scenarios use fixed ports (2121 plain, 2122 FTPS implicit, 2123 FTPS explicit). Two parallel runs of `make test-integration` on the same host collide. CI is fine (single workflow run), but local development is bottlenecked.

## Affected code

- tests/integration/lib/common.sh — port constants
- tests/integration/scenarios/* — port references

## Reproduction

1. Open two terminals.
2. Run `make test-integration` in both.
3. Observe: second run fails with 'port already in use'.

## Suggested fix

Pick ports at runtime from an env var (TEST_FTP_PORT, TEST_FTPS_IMPLICIT_PORT, TEST_FTPS_EXPLICIT_PORT) with safe defaults (2121-2123). Pass the ports into start_ftps_server.

Or use ephemeral port allocation (bind to 0, read back the bound port).

The first option is simpler.

## Source

F2 audit 2026-09-03 (tests audit). Reporter: subagent-pekodbj7.

## Related

- Part of EPIC #[epic-number]
- Closes: #NONE (no existing issue)
- Related: M6 (sleep 1 for bind-mount propagation)"

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。