airbytehq / airbytehq/airbyte

Refreshes do not trigger sync notifications

オープン
#84,410 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る
autoteam community needs-triage team/use
主要言語
Python
スター
22.1k
フォーク
5.3k
PR マージ指標
PR 指標を取得中

説明

### Topic

Refresh syncs do not trigger the execution of sync notifications, such as Successful Sync, Failed Sync

### Relevant information

## Platform Version

* Edition: community
* Version: Observed on 1.0.0, reproduced through 2.2
* Deployment: GKE, local abctl

## Description

Triggering a [Refresh Sync](https://docs.airbyte.com/platform/operator-guides/refreshes) does not appear to execute any of the [webhook notifications associated with sync events](https://docs.airbyte.com/platform/cloud/managing-airbyte-cloud/manage-airbyte-cloud-notifications#events-airbyte-can-notify-you-about).

This is surprising because my impression from the documentation is that refresh syncs are considered to be syncs, and I'd expect to be able to notify on their success/failure (since they have similar effects - changes in the synced data).

The code in `JobCreationAndStatusUpdateHelper.kt` defines [`val SYNC_CONFIG_SET: Set = setOf(ConfigType.SYNC, ConfigType.REFRESH)`](https://github.com/airbytehq/airbyte-platform/blob/dcaef5c05a1dfd5e90d3ebbce9a397c29290cd25/airbyte-commons-server/src/main/kotlin/io/airbyte/commons/server/handlers/helpers/JobCreationAndStatusUpdateHelper.kt#L590), which seems in line with the documentation. The `JobsHandler` class though [conditions sync notification execution on `ConfigType.SYNC` rather than `SYNC_CONFIG_SET`](https://github.com/airbytehq/airbyte-platform/blob/dcaef5c05a1dfd5e90d3ebbce9a397c29290cd25/airbyte-commons-server/src/main/kotlin/io/airbyte/commons/server/handlers/JobsHandler.kt#L201-L203), meaning `ConfigType.REFRESH` do not emit notifications.

## Steps to reproduce

1. Have a connection that supports [Refresh Syncs](https://docs.airbyte.com/platform/operator-guides/refreshes)
2. Configure and enable webhooks for Successful sync, Failed sync per https://docs.airbyte.com/platform/cloud/managing-airbyte-cloud/manage-airbyte-cloud-notifications#set-up-webhook-notifications
3. Sync the connection - observe notifications trigger.
4. Refresh the connections - no notifications trigger.

---
**Internal Tracking:** https://github.com/airbytehq/oncall/issues/13311

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。