docs: ambiguous IP notation `34.33.7.[0,8]` in the Cloud IP allow list
- Vorherrschende Sprache
- Python
- Sterne
- 22.1k
- Forks
- 5.3k
- PR-Merge-Kennzahlen
- PR-Kennzahlen ausstehend
Beschreibung
cc @ian-at-airbyte — flagging a docs ambiguity found via a support ticket (Zendesk #18968).
## What
The Cloud IP allow list (https://docs.airbyte.com/platform/operating-airbyte/ip-allowlist, source: `docusaurus/static/_airbyte_cloud_ips.md`) lists:
| Geography | Region | IP address (CIDR) | IP addresses |
| --- | --- | --- | --- |
| United States | us-central-1 | 34.33.7.0/29 | 34.33.7.[0,8] |
The `34.33.7.[0,8]` notation is ambiguous. Bracket notation normally reads as "`.0` and `.8`" or "`.0` through `.8`", but neither matches `34.33.7.0/29`, which covers 8 addresses: `34.33.7.0`–`34.33.7.7`. `34.33.7.8` is outside the block. It appears to have been intended as "8 addresses starting at .0".
## Why it matters
A customer's vendor refuses to allowlist CIDR ranges and asked for the explicit address list. The docs notation led them to believe the list ran up to `.8`.
## Verification
The us-central1 dataplane NAT egress addresses provisioned in `airbytehq/gitops` are named `prod-dataplane-gcp-us-central1-pool-34-33-7-0` through `...-7` (see `env/prod/infra/network/vpc/prod-dataplane-gcp-us-central1-0/terragrunt.hcl` and `env/prod/infra/network/vpc/prod-data-plane-gcp-us-central1-1/terragrunt.hcl`), i.e. exactly `34.33.7.0`–`34.33.7.7`.
Note: `airbyte-platform-internal` `infra/gcp/env/prod/values.tf` reserves `34.33.7.0`–`34.33.7.15` for this dataplane, so it would be worth confirming with infra whether the published range should stay a `/29` or be widened.
## Suggested fix
Replace `34.33.7.[0,8]` with an unambiguous form, e.g. `34.33.7.0 - 34.33.7.7`, or list the eight `/32` addresses explicitly for customers whose firewalls do not accept CIDR ranges.
Introduced in https://github.com/airbytehq/airbyte/pull/61367.
---
**Internal Tracking:** https://github.com/airbytehq/oncall/issues/13212
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.