airbytehq / airbytehq/airbyte

bug(source-mssql): CDC check crashes on localized SQL Server Agent service names

Offen
#82,785 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
autoteam connectors/source/mssql hyd-review team/db-dw-sources
Vorherrschende Sprache
Python
Sterne
22.1k
Forks
5.3k
PR-Merge-Kennzahlen
PR-Kennzahlen ausstehend

Beschreibung

## Summary

CDC-enabled `source-mssql` connection checks crash on localized (non-English) SQL Server installations with:

```
java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
```

## Root cause

`assertSqlServerAgentRunning` (in `MsSqlSourceMetadataQuerier.kt`) looks up the SQL Server Agent service with a hard-coded `LIKE 'SQL Server Agent%'`. German installations name the service `SQL Server-Agent` (hyphen), so the query returns zero rows and the connector indexes into an empty result while validating that the Agent is "Running".

## Impact

Users on localized SQL Server instances cannot set up CDC replication at all, even when the Agent is running correctly. `source-mssql` is a certified connector.

## History

- Previously reported in #66582, which was closed as completed even though the fix never landed.
- Community PR #72867 proposed widening the `LIKE` pattern. That PR was closed on 2026-07-27 as part of a stale-PR cleanup (no maintainer review in ~5 months, no test covering localized service names) — the underlying bug was not disputed, hence this issue.

## Suggested fix

Match the service name without assuming English punctuation/wording, and fail with a clear error message (rather than an index-out-of-bounds) when no Agent row is found. A regression test with a localized service name would prevent the next recurrence.

---
Filed at the request of @jimruppert while triaging the community PR backlog.
[Devin session](https://app.devin.ai/sessions/12011a91f2d541f0826863290e5ad30c)

---
**Internal Tracking:** https://github.com/airbytehq/oncall/issues/13170

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.