airbytehq / airbytehq/airbyte

source-shortio: Clicks stream broken, api-v2.short.cm domain decommissioned, needs migration to statistics.short.io

Aperta
#82,681 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
area/connectors autoteam community connectors/source/shortio hyd-review needs-triage team/extensibility team/use type/bug
Lingua principale
Python
Stelle
22.1k
Fork
5.3k
Metriche di merge delle PR
Metriche PR in attesa

Descrizione

### Connector Name

source-shortio

### Connector Version

0.3.57

### What step the error happened?

Configuring a new connector

### Relevant information

## Description

The `clicks` stream in `source-shortio` is broken. The `api-v2.short.cm` host has been decommissioned by Short.io, returning a `404 Domain not found` HTML page instead of JSON.

The `links` stream still works because it already uses `api.short.io`.

## Error

GET request to `https://api-v2.short.cm/statistics/domain//link_clicks` failed with status code '404' and error message: 'Domain not found'

## Root Cause

The old `link_clicks` GET endpoint no longer returns raw click data. The equivalent endpoint is now [`last_clicks`](https://developers.short.io/reference/postdomaindomainidlast_clicks) (POST) and `https://api-v2.short.cm/statistics/` is now `https://statistics.short.io/statistics/`

## Proposed Fix

Three changes in `manifest.yaml` for the clicks stream requester:

| Field | Current (broken) | Fix |
|---|---|---|
| `url_base` | `https://api-v2.short.cm/statistics/` | `https://statistics.short.io/statistics/` |
| `path` | `domain/{{ config['domain_id'] }}/link_clicks` | `domain/{{ config['domain_id'] }}/last_clicks` |
| `http_method` | `GET` | `POST` |

The `last_clicks` endpoint returns the same raw click record schema (`dt`, `host`, `path`, `ip`, `browser`, `country`, `os`, `ua`, `utm_source`, etc.) and in addition the following new fields: `geoname_id`, `utm_term`, `utm_content`, `lcpath`.

### Relevant log output

```shell
source ERROR 'GET' request to 'https://api-v2.short.cm/statistics/domain/XXXX/link_clicks' failed with status code '404'
```

### Contribute

- [x] Yes, I want to contribute

---
**Internal Tracking:** airbytehq/oncall#13132

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.