airbytehq / airbytehq/airbyte

Airbyte CDK: `generate.sh` produces `Source`- rather than `AbstractSource`-based source for Python Source

Offen
#8,184 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
autoteam CDK community connector-templates frozen Icebox team/connectors-python team/use type/enhancement
Vorherrschende Sprache
Python
Sterne
22.1k
Forks
5.3k
PR-Merge-Kennzahlen
PR-Kennzahlen ausstehend

Beschreibung

Currently, `generate.sh` for Python Source generates a template `source.py` file with `Source` as the base class for the template source.

However, AFAIK `source.py` file should use `Stream` and `AbstractSource` classes as these are the suggested ones and also easier to implement.

Here is the place in the docs where you state that this is how the CDK should be used:

![image](https://user-images.githubusercontent.com/23084949/142942999-d00c45ca-dfc1-45ce-a7fa-5ae74ea1bcae.png)

This was quite confusing for me to read as I just followed your tutorial on how to get started and got an autogenerated file that doesn't conform to this. I think the whole intro docs assume the person uses these classes rather than `Source` - eg. the next section describes the use of `Stream.get_json_schema`:
![image](https://user-images.githubusercontent.com/23084949/142943425-dc0226a4-8005-40da-a68e-5961bad11753.png)

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.