airbytehq / airbytehq/airbyte

Google application credentials for logging are double base64 encoded in airbyte-secrets

Ouverte
#68,178 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
area/platform autoteam community needs-triage team/compose team/documentation team/platform-move type/bug
Langage dominant
Python
Étoiles
22.1k
Forks
5.3k
Métriques de merge des PR
Métriques de PR en attente

Description

### Helm Chart Version

2.0.18

### What step the error happened?

None

### Relevant information

The gcs log creds secret loads the credentials json file using the `data` key:

https://github.com/airbytehq/airbyte-platform/blob/4f7d9b0e3ab58c518ea90da473a8934c674a911b/charts/v2/airbyte/templates/gcs-log-creds-secret.yaml#L15-L18

But the main `airbyte-secrets` secret uses `stringData` so the storage credentials are encoded twice. I fixed this with a manual transformation for now. You can probably work around it by making a logging secret yourself and then pass a non-base64'd version into `global.storage.gcs.credentialsJson` but the docs do ask for a base64'd version. Kind of strange.

https://github.com/airbytehq/airbyte-platform/blob/4f7d9b0e3ab58c518ea90da473a8934c674a911b/charts/v2/airbyte/templates/secret.yaml#L10-L28

### Relevant log output

```shell

```

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.