airbytehq / airbytehq/airbyte

Destination MS SQL connector doesn't support NVARCHAR

Offen
#64,496 4 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
area/connectors autoteam community connectors/destination/mssql needs-triage team/extensibility type/bug
Vorherrschende Sprache
Python
Sterne
22.1k
Forks
5.3k
PR-Merge-Kennzahlen
PR-Kennzahlen ausstehend

Beschreibung

### Connector Name

destination-mssql

### Connector Version

2.2.12

### What step the error happened?

During the sync

### Relevant information

Destination MS SQL connector doesn't support NVARCHAR, it uses TEXT for objects and arrays, which deprecated and doesn't support unicode. Is it possible to add NVARCHAR(MAX) support into type mappings?

### Relevant log output

```shell
class AirbyteTypeToMssqlType {
fun convert(airbyteSchema: AirbyteType, isIndexed: Boolean = false): MssqlType {
return when (airbyteSchema) {
is ObjectType -> MssqlType.NVARCHAR
is ArrayType -> MssqlType.TEXT
is ArrayTypeWithoutSchema -> MssqlType.TEXT
is BooleanType -> MssqlType.BIT
is DateType -> MssqlType.DATE
is IntegerType -> MssqlType.BIGINT
is NumberType -> MssqlType.DECIMAL
is ObjectTypeWithEmptySchema -> MssqlType.TEXT
is ObjectTypeWithoutSchema -> MssqlType.TEXT
is StringType -> if (isIndexed) MssqlType.VARCHAR_INDEX else MssqlType.VARCHAR
is TimeTypeWithTimezone -> MssqlType.DATETIMEOFFSET
is TimeTypeWithoutTimezone -> MssqlType.TIME
is TimestampTypeWithTimezone -> MssqlType.DATETIMEOFFSET
is TimestampTypeWithoutTimezone -> MssqlType.DATETIME
is UnionType -> MssqlType.TEXT
is UnknownType -> MssqlType.TEXT
}
}
}
Does MssqlType have MssqlType.NVARCHAR
```

### Contribute

- [ ] Yes, I want to contribute

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.