airbytehq / airbytehq/airbyte

Platform Chart changes to Temporal Deployment causing TLS issues.

Abierto
#43,328 31 comentarios 7 reacciones 0 asignados Ver en GitHub
area/platform community team/deployments type/bug
Lenguaje dominante
Python
Estrellas
22.1k
Forks
5.3k
Métricas de merge de PR
Métricas de PR pendientes

Descripción

### Helm Chart Version

0.399.0

### What step the error happened?

On deploy

### Relevant information

The Temporal Deployment manifest was [changed](https://github.com/airbytehq/airbyte-platform/commit/4731a0b246eb9767ec61faf211097c8f0f68fb5b) to assume that TLS\SSL is needed if using an external Database:

```
{{- if eq .Values.global.database.type "external" }}
# Assume an external database requires SSL.
- name: POSTGRES_TLS_ENABLED
value: "true"
- name: POSTGRES_TLS_DISABLE_HOST_VERIFICATION
value: "true"
- name: SQL_TLS_ENABLED
value: "true"
- name: SQL_TLS_DISABLE_HOST_VERIFICATION
value: "true"
{{- end }}
```

This causes significant issues when using, for example, a sidecar Proxy which does not require TLS.

We should not be making an assumption here. In my opinion, there should be a key value pair in values which enables \ disables TLS\SSL if required in the deployment.

E.G.

```
temporal:
enabled: true
externalSSL: false
```

### Relevant log output

```shell
[Fx] Error returned: received non-nil error from function "go.temporal.io/server/temporal".ServerOptionsProvider
/home/builder/temporal/temporal/fx.go:180:
sql schema version compatibility check failed: pq: SSL is not enabled on the server
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.