airbytehq / airbytehq/airbyte

Destination Google Sheets: clears rows, should delete rows

Abierto
#25,126 3 comentarios 2 reacciones 0 asignados Ver en GitHub
area/connectors community connectors/destination/google-sheets connectors/destinations-api frozen releaseStage/alpha team/destinations type/bug
Lenguaje dominante
Python
Estrellas
22.1k
Forks
5.3k
Métricas de merge de PR
Métricas de PR pendientes

Descripción

## Environment
- **Destination Connector and version**: 0.1.2
- **Step where error happened**: Sync job

## Current Behavior
Full refresh/Overwrite: Destination sheet progressively fills with empty rows over time

## Expected Behavior
Destination sheet should not fill with empty rows over time

## Exact problem code:
In spreadsheet.py, the clean_worsheet() method calls the pygsheets clear() method

In writer.py, the write_from_queue() method calls the pygsheets append_table() method

The clear() method doesn't remove rows, it only empties them.

So the sync inserts new rows but doesn't remove the previous rows.

clean_worksheet() should probably call the pygsheets delete_rows() method instead of clear()

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.