airbytehq / airbytehq/airbyte

JDBC URL should be part of the PostgresReplicationConnection functionality

Aperta
#23,380 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
connectors/source/postgres frozen team/db-dw-sources type/enhancement
Lingua principale
Python
Stelle
22.1k
Fork
5.3k
Metriche di merge delle PR
Metriche PR in attesa

Descrizione

# What
In order to make easier the creation of `replication` type of connections we created the class `PostgresReplicationConnection`.
We added a new a default value for JDBC URL when it has not been defined in the config in an attempt to facilitate the connection creation, but it doesn't work for SSL connections.

If you need to create a SSL Replication connection, you need to first call `getDatabaseConfig` function from a `JdbcDatabase` object (`database`):
```
JsonNode databaseConfig = database.getDatabaseConfig();
```

And then call the create function with that config:
```
final Connection connection = PostgresReplicationConnection.createConnection(databaseConfig)
```

# Solution
Use the config on the function `createConnection` in order to automatically generate the required parameters when creating the connection.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.