airbytehq / airbytehq/airbyte

Snowflake Destination: need support for multi-byte identifiers

Aperta
#18,058 7 commenti 0 reazioni 0 assegnatari Vedi su GitHub
autoteam community connectors/destination/snowflake connectors/destinations-db frozen lang/java team/destinations type/enhancement
Lingua principale
Python
Stelle
22.1k
Fork
5.3k
Metriche di merge delle PR
Metriche PR in attesa

Descrizione

## Tell us about the problem you're trying to solve
I'm trying to create a connection with the Snowflake destination connector with “Destination Namespace” set to “Custom format”, and “Namespace Custom Format” set to something like “airbyte.io コーポレートサイトGA” which contains multi-byte characters and generates a schema named exactly the same as the custom format.
Instead, I get a schema name defined as “AIRBYTE_IO__________GA” and there would be only `_AIRBYTE_RAW_` tables inside.
Every Snowflake identifier should be enclosed by double quotes as described in [Identifier Requirements — Snowflake Documentation](https://docs.snowflake.com/en/sql-reference/identifiers-syntax.html#label-identifier-casing) to support multi-byte characters for identifiers.

## Describe the solution you’d like
The value of Namespace Custom Format should be enclosed by double quotes.

## Describe the alternative you’ve considered or used
I tried some variations such as `"airbyte.io コーポレートサイトGA"`, `\"airbyte.io コーポレートサイトGA\"`, `\\"airbyte.io コーポレートサイトGA\\"`, `""airbyte.io コーポレートサイトGA""`, but to no avail. They all ended up with extra underscores.
We allow our users to name the Snowflake schema via Airbyte API as they wish, so it's inevitable to handle multi-byte characters, Japanese in our case.

## Additional context
I already opened a ticket, https://discuss.airbyte.io/t/snowflake-destination-connector-does-not-support-multi-bytes-identifiers/2923 , but @natalyjazzviolin kindly redirected me here.

## Are you willing to submit a PR?

No

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.