airbnb / airbnb/synapse

dns watcher ping assumes dns server resolves public addresses

Open
#28 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Ruby
Stars
2.1k
Forks
248
PR merge metrics
No merged PRs in 30d

Description

The dns watcher's ping method declares the watcher dead if it can't resolve airbnb.com. This doesn't work if you are in a private network (e.g. AWS VPC) and are using a DNS server that only resolves private domains.

Potential alternatives:
- allow the domain for the ping to be configurable
- don't care if the domain is not found (the fact that it got a proper response from the dns server is good enough)

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the DNS watcher's ping method and reproduce its behavior with a DNS server that resolves only private domains. Decide which proposed behavior the project should use, then verify that a valid response from the DNS server no longer incorrectly marks the watcher dead.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.