airbnb / airbnb/synapse

No support for relative server_port overrides

Open
#234 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
2.1k
Forks
248
PR merge metrics
No merged PRs in 30d

Description

haproxy supports relative port addresses, prefixed by a "+" or "-".

If this is set the server port is determined by adding the value to the client's port. In the base service_watcher there is currently a check to verify that the override port is an integer which breaks existing configurations.

I assume nginx doesn't support a similar behaviour, would you accept a patch or should we just maintain our own version?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the base service_watcher check that requires server_port overrides to be integers. Compare HAProxy's +/− relative-port behavior with the existing configuration handling; done means valid relative overrides no longer fail validation while existing configurations remain supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.