airbnb / airbnb/react-with-styles

Does not work with `react-transition-group`

Open
#133 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.7k
Forks
101
PR merge metrics
No merged PRs in 30d

Description

For some reason, having a `withStyles` wrapped component as a child of a `TransitionGroup` breaks things and prevents the lib from seeing `componentWillLeave` and other lifecycle methods it needs access to.

@jeduan @lencioni @airbnb/webinfra

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the failure with a withStyles-wrapped component inside a TransitionGroup, focusing on how componentWillLeave and related lifecycle methods are exposed. There are no files or tests named in the issue; done means the transition library can access the required lifecycle methods and the regression is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.