airbnb / airbnb/react-with-direction
React 17
- Dominant language
- JavaScript
- Stars
- 189
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
React 17 is around the corner and this package still relies on the unsafe `componentWillRecieveProps`. I attempted to make a pr to mark it as unsafe but this breaks with pre 16 react versions. Can we move forward and remove support for pre 16 react? If not switching to `componentDidUpdate` in this PR https://github.com/airbnb/react-with-direction/pull/14 seems like the logical way forward.
Contributor guide
No contributing guide indexed for this repository
Research direction
Review the React 17 issue and the linked pull request #14 first, then trace where componentWillRecieveProps is used and how the package supports pre-16 React versions. Done means the chosen lifecycle approach is implemented without the React 17 unsafe-lifecycle problem, with the compatibility decision made explicit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100