airbnb / airbnb/react-sketchapp

renderToJson broken in 3.2.5

Open
#519 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14.9k
Forks
797
PR merge metrics
No merged PRs in 30d

Description

**Expected behavior:**

**Observed behavior:** when I update the version from 3.1.2 to 3.2.5 , report error "undefined is not an object (evaluating 'bridge.createStringMeasurer') "

**How to reproduce:**
![image](https://user-images.githubusercontent.com/15276351/83972652-fa7a1900-a913-11ea-8d6b-789e95bdb7ba.png)
![image](https://user-images.githubusercontent.com/15276351/83972659-05cd4480-a914-11ea-9525-041ae68822dd.png)

**Sketch version:** 66

But it work when i change the import:
![image](https://user-images.githubusercontent.com/15276351/83972808-de2aac00-a914-11ea-83ef-1948d0eaf668.png)
May be related to this pr #517

Contributor guide

Open the contributing guide

Research direction

Start by comparing the renderToJson import that works with the failing import after upgrading from 3.1.2 to 3.2.5, then review PR #517 for related changes. Reproduce the error in Sketch 66 and confirm that renderToJson no longer reports the missing bridge.createStringMeasurer error.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.