airbnb / airbnb/react-sketchapp

[Feature-request] Add controls for 'manage overrides' in symbols

Open
#430 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
14.9k
Forks
797
PR merge metrics
No merged PRs in 30d

Description

_I am a designer and developer, at the beginning stages of updating our existing design system sketch library to a new one with reactsketchapp_

We currently use a lot of nested symbols where we set additional rules on the parent symbol to prevent overrides to some child symbols.

**Example: Form Label component**

![image](https://user-images.githubusercontent.com/5712890/61552511-e16f2d80-aa0c-11e9-8c8d-eb40be88024d.png)
This symbol is used within all our form components (inputs, dropdowns, checkboxes, etc.)
I want to use the "manage overrides" feature in sketch to limit what can be overridden on the symbol when nested in parent symbols.

The manage overrides setting in sketch:

![image](https://user-images.githubusercontent.com/5712890/61552433-aec53500-aa0c-11e9-8bbd-6c811cb580cc.png)

Does this exist currently or can we add support for this functionality. Thanks in advance!

Contributor guide

Open the contributing guide

Research direction

Start by tracing how react-sketchapp represents nested symbols and compare that behavior with Sketch's “Manage Overrides” controls shown in the issue. No source file or test is named, so first identify the symbol-handling entry points and existing coverage. Done means establishing whether override controls are supported and, if not, defining and implementing the requested controls with tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.