airbnb / airbnb/react-sketchapp

Investigate removing "special" meaning of symbols page

Open
#316 1 comment 0 reactions 0 assignees View on GitHub
enhancement technical
Dominant language
TypeScript
Stars
14.9k
Forks
797
PR merge metrics
No merged PRs in 30d

Description

There are several branches of logic that place a special meaning on the "Symbols Page". It is worth investigating if we can remove these branches in order to simplify internals and provide a more consistent and expected interface.

---

Discussed during review of #297

> mathieudutour: I'm wondering if we really need to forbid rendering into the Symbols page. There is nothing special about in Sketch except being the default location where symbols are going but they can be created in any page and you can any type of layers to the Symbols page

> jaridmargolin: I more or less agree with your sentiment, but I think that is a larger question that would need to be addressed in a standalone task. The current implementation of symbols makes a few assumptions about the Symbols page.

---

cc @mathieudutour

Contributor guide

Open the contributing guide

Research direction

Start with the Symbols Page handling and the symbols implementation assumptions described in this issue, then read the review discussion in #297. Identify each branch that gives the page special treatment and determine whether removing those assumptions can preserve a consistent interface; done means the scope and required changes are clearly established.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.