airbnb / airbnb/react-sketchapp
Cleanup shared text style lookup
Open
enhancement
technical
- Dominant language
- TypeScript
- Stars
- 14.9k
- Forks
- 797
- PR merge metrics
- No merged PRs in 30d
Description
#290 fixes Shared text styles lookup that was broken since switching to yoga-layout.
It does so in quite a brutal way and we believe there is a more proper solution.
See https://github.com/airbnb/react-sketchapp/pull/290#discussion_r185983026 for more context
cc @jaridmargolin
Contributor guide
Research direction
Start with PR #290 and the linked discussion for the existing Shared text styles lookup workaround and the context around the yoga-layout switch. Compare that behavior with the intended lookup approach; done means the workaround is replaced by a proper solution without breaking shared text style lookup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- design
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100