airbnb / airbnb/react-sketchapp

Causes a continuous increase in memory usage

Open
#284 2 comments 0 reactions 0 assignees View on GitHub
bug technical
Dominant language
TypeScript
Stars
14.9k
Forks
797
PR merge metrics
No merged PRs in 30d

Description

I am a Sketch Plug-in developer.

**Expected behavior:**

Sketch occupies almost no fluctuation in memory usage each time the plugin command containing `react-sketchapp` is called.

**Observed behavior:**

Each call to the command increases Sketch's non-recoverable memory footprint

**How to reproduce:**

See [antd-sketchapp](https://github.com/ant-design/antd-sketchapp/blob/master/docs/en-us/development.md#how-to-preview) demo.

**Sketch version:**

All versions.

**Please attach screenshots, a zip file of your project, and/or a link to your github project**

![kapture 2018-03-14 at 16 27 43](https://user-images.githubusercontent.com/2953176/37391010-e9333e6c-27a4-11e8-8783-723fcc1bbf3b.gif)

Contributor guide

Open the contributing guide

Research direction

Start with the antd-sketchapp demo linked in the reproduction steps and run the Sketch plugin command repeatedly while monitoring Sketch's non-recoverable memory footprint. Trace the react-sketchapp command path from that demo; done means repeated calls no longer cause continuous memory growth across the reported Sketch versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
desktop-dev, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.