airbnb / airbnb/react-outside-click-handler

The event "mousedown" is not fired on mobile properly

Open
#11 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
611
Forks
64
PR merge metrics
No merged PRs in 30d

Description

I'm using 'react-dates' library and on my iphone5 handler `onOutsideClick` is not fired properly.
It's fired when I click on the button, but not if I click on an empty space background.

I've added 'touchstart' event for my component and now it's fine.

Can we extend current event listener with `touchstart`?

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the component's existing mousedown event listener and the reported onOutsideClick behavior, starting with the event-handling entry point. Verify the iPhone/touch case described in the issue; done means touches on empty mobile background trigger onOutsideClick as requested.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.