airbnb / airbnb/native-navigation

[Android] Abstract serialiser

Open
#130 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.1k
Forks
173
PR merge metrics
No merged PRs in 30d

Description

Currently the android library uses Jackson as a serialisation library. This makes Jackson a transitive dependency that lands in the consumers dependency tree.

My proposal would be to adapt a more agnostic approach and create an abstraction layer like a Converter (similar to the one in https://github.com/square/retrofit) and allow consumers to select different types of implementations via different artefacts.
There are at least 3 popular libraries used in Android development, so at lest does can be added as standalone artefacts:
- `native-navigation-converter-gson` for [Gson](https://github.com/google/gson)
- `native-navigation-converter-moshi` for [Moshi](https://github.com/square/moshi/)
- `native-navigation-converter-jackson` forJackson.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the Android library's current Jackson integration and compare the proposed abstraction with Retrofit's Converter approach. Done means consumers can choose separate Gson, Moshi, or Jackson converter artefacts without Jackson becoming a transitive dependency.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java, react-native
Domain
mobile
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.