airbnb / airbnb/javascript

Integrate "eslint-plugin-eslint-comments" plugin

Open
#2,049 0 comments 8 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
148k
Forks
26.6k
PR merge metrics
No merged PRs in 30d

Description

When disabling some eslint rule, it's very easy to make mistakes like not enabling it again, forgetting to remove the disabled rule when the code is refactored...

`eslint-plugin-eslint-comments` checks those cases, allowing a safer way of disabling eslint rules: https://mysticatea.github.io/eslint-plugin-eslint-comments/rules/

I think it would be very useful to include it in `eslint-config-airbnb-base` (maybe just as a warning initially, to avoid a breaking change).

Before creating a PR adding it, I would like to gather feedback about it: do you think this would be a useful addition?

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the eslint-plugin-eslint-comments rules and the eslint-config-airbnb-base configuration to assess whether the plugin fits the project. Gather feedback on enabling it as warnings or enforcing it as a breaking change. The issue is complete when a decision is made about whether and how to integrate the plugin.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, javascript
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.