airbnb / airbnb/binaryalert

Allow binaryalert to scan buckets created outside of module

Open
#170 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.5k
Forks
179
PR merge metrics
No merged PRs in 30d

Description

## Background

Users may want binaryalert to scan buckets that were created outside of the module. It should support this functionality.

Weirdly, it looks like this functionality was partly included as [documented here](https://github.com/airbnb/binaryalert/blob/master/docs/source/analyzing-files.rst#configuring-event-notifications), via the variables:

- `external_s3_bucket_resources`
- `external_kms_key_resources`

But a more automated way should be implemented so the user doesn't need to change anything.

## Desired Change

Create new variable `external_s3_bucket_arns` that will notify the analyzer SQS queue on new objects created. Adjust permissions accordingly.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.