airbnb / airbnb/DeepLinkDispatch

Custom path matching regex

Open
#93 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
4.4k
Forks
414
PR merge metrics
No merged PRs in 30d

Description

Currently I have seen that the regex (DeepLinkEntry.PARAM_VALUE) is "([a-zA-Z0-9_#!+%~,\-\.\$]*)".
However I have url deeplinks that contains other characters, for example '&'.
https://www.mycompany.com/foo%20&%20bar

So they will not match.

The proposal is to allow the client to customize this regex. (Maybe using meta-data tag in the manifest?)

Thanks.

Contributor guide

Open the contributing guide

Research direction

Start by locating DeepLinkEntry.PARAM_VALUE and the manifest metadata handling; verify how the example URL containing '&' is parsed. Define the customization mechanism and its default behavior, then add coverage for the example URL before considering the issue done.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.