airbnb / airbnb/DeepLinkDispatch

Handle Uris with no host and params (e.g 'airbnb://')

Open
#70 11 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Kotlin
Stars
4.4k
Forks
414
PR merge metrics
No merged PRs in 30d

Description

Not sure if it's a bug or on purpose but DeepLinkDispatch does not handle Uris with just the base scheme, like `airbnb://`. In that case, `DeepLinkUri.parse()` with return `ParseResult.INVALID_HOST`. Not sure if we should handle it, any other thoughts?

Contributor guide

Open the contributing guide

Research direction

Start by reading the implementation of DeepLinkUri.parse() and how ParseResult.INVALID_HOST is handled. Review the existing discussion to determine whether a URI such as `airbnb://` should be accepted or rejected, then define regression coverage and the expected result once that behavior is decided.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.