airbnb / airbnb/DeepLinkDispatch

Deeplinks cannot be found in registry classes between 4.1 -> 5.1

Open
#285 2 comments 4 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
4.4k
Forks
414
PR merge metrics
No merged PRs in 30d

Description

I'm upgrading my company's DLD version from 4.1 -> 5.1. Based on your documentation all I needed to do was change any instance of the word `Loader` to `Registry`

I handle deeplinks by calling deepLinkDelegate.dispatchFrom(activity) and several of my integration tests (and actual implementation) have begun to fail. After doing some debugging I've found that entries in the registry that should match the provided uri are not matched by `idxMatch`

Contributor guide

Open the contributing guide

Research direction

Start at deepLinkDelegate.dispatchFrom(activity) and inspect how idxMatch searches registry entries during the 4.1-to-5.1 migration. Reproduce the failing integration case and confirm the fix when a URI that should match is found and dispatched through the registry.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.