airbnb / airbnb/DeepLinkDispatch

onActivityResult not called in DeepLinkActivity

Open
#264 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
4.4k
Forks
414
PR merge metrics
No merged PRs in 30d

Description

Is there anything special about doing `startActivityForResult` in `DeepLinkActivity`? For some reason, `onActivityResult` is never being called.

To provide some context, the usecase I'm trying to solve is:
1. Catch the deeplink Uri
2. Start authentication flow with `startActivityForResult`
3. Come back to `onActivityResult` and dispatch the original Uri.

Contributor guide

Open the contributing guide

Research direction

Start by reading DeepLinkActivity and tracing the startActivityForResult flow to determine why onActivityResult is not reached. Reproduce the deeplink authentication sequence described in the issue. Done means the authentication result returns to onActivityResult and the original Uri is dispatched.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.