airbnb / airbnb/DeepLinkDispatch

URL encoding before parsing

Open
#226 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
4.4k
Forks
414
PR merge metrics
No merged PRs in 30d

Description

I have a use case in which I have a url with a special character in its path (something like https://host.com/#/path/{path_id} ). Now if I declare a url with something like this, https://host.com/#/path/{path_id} with @DeepLink annotation , the everything after # is regexed into "$", hence i am not able to separate out the path_id from it. Therefore, it is defeating the entire purpose of using this library as then i have to manually split the url and find out the path id. I suggest that there should be a support to URL encode such urls as well , so that these special charachters ( like "#" in my case) gets removed .

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue with an @DeepLink URL containing a # fragment and inspect where the URL is parsed and converted into a regex. Determine the intended handling for encoded special characters, then verify that the path_id remains separable without manual URL splitting.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.