airbnb / airbnb/DeepLinkDispatch

Validation/Default fallback Intent

Open
#155 5 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Kotlin
Stars
4.4k
Forks
414
PR merge metrics
No merged PRs in 30d

Description

Currently individual deep link handler methods/Activities need to do the following manually:

1. Validate the deep link URI. The framework takes care of most of this, but query parameters and parameter values still need to be validated manually.
2. Ensure certain pre-conditions are true (e.g. user must be logged in)
3. Be explicitly aware of the fallback Intent to use if the URI is invalid or a global pre-condition is false

It'd be nice if the framework could help reduce that boilerplate. Note a solution doesn't necessarily need to address all of the issues above. Let me know if this is something we want, and if so we can bounce on some ideas for what the API for this might look like.

Contributor guide

Open the contributing guide

Research direction

The issue names no files or tests. Start by reading the individual deep link handler methods and Activities, then trace how URI validation, preconditions, and fallback Intents are currently handled. Done would require an agreed framework API and scope for reducing that boilerplate.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.