aio-libs / aio-libs/yarl

[TODO] Fix coverage collection for Cython modules

Ouverte
#1,581 2 commentaires 0 réactions 2 personnes assignées Réclamée par @rodrigobnogueira Voir sur GitHub
bug help wanted
Langage dominant
Python
Étoiles
1.5k
Forks
215
Merge moyen
1 j 2 min
PR mergées (30 j)
13

Description

### Please confirm the following

- [x] I agree to follow the [aio-libs Code of Conduct][CoC]

[CoC]: ../../.github/blob/master/CODE_OF_CONDUCT.md

- [x] I have checked the [current issues][issue search] for duplicates.

[issue search]: ../search?q=is%3Aissue&type=issues

- [x] I understand this is open source software provided for free and that I might not receive a timely response.
- [x] I am positive I am **NOT** reporting a (potential) security
vulnerability, to the best of my knowledge. *(These must be shared by
submitting [this report form][vulnerability report form] instead, if
any hesitation exists.)*

[vulnerability report form]: ../security/advisories/new

- [ ] I am willing to submit a pull request with reporoducers as xfailing test cases or even entire fix. *(Assign this issue to me.)*

### Describe the bug

Some time between https://app.codecov.io/gh/aio-libs/yarl/commit/d1286dbe71ea1caaf7c8e488b608ae1637702e90 (https://github.com/aio-libs/yarl/commit/d1286dbe71ea1caaf7c8e488b608ae1637702e90) and https://app.codecov.io/gh/aio-libs/yarl/commit/63c446174218bdcd31274b4488e513de1a05c54e (https://github.com/aio-libs/yarl/commit/63c446174218bdcd31274b4488e513de1a05c54e) Codecov forgot about the existance of Cython modules entirely.
Need to bisect that and see what happened.

### To Reproduce

🤷‍♂️

### Expected behavior

`*.pyx` files should show coverage.

### Additional context

The same thing is happening in another project with identical setup: https://github.com/ansible/pylibssh/issues/781.

The only thing suspicious in the diff is the changes to the `linetrace` setting: https://github.com/aio-libs/yarl/compare/d1286db...63c4461. However, `ansible-pylibssh` still has this setting on and has this problem nevertheless. So I think this might be unreleated.

My guess is that perhaps Cython was unpinned at the time and we didn't notice when this changed.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.